gh-107901: synthetic jumps which are not at end of loop no longer check the eval breaker#113721
Merged
Conversation
iritkatriel
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
January 5, 2024 00:48
iritkatriel
changed the title
markshannon
requested changes
Jan 5, 2024
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
I think we need to convert JUMP -> JUMP_NO_INTERRUPT to JUMP.
Otherwise, looks good.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
I have made the requested changes; please review again. |
chris-eibl
reviewed
Jan 6, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…er check the eval breaker (python#113721)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…er check the eval breaker (python#113721)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…er check the eval breaker (python#113721)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes some of the synthetic non-loop JUMPs to be JUMP_NO_INTERRUPT.
The has two advantages: